Apache OpenOffice (AOO) Bugzilla – Issue 68825
new chart: need to remove redo action for chart that got removed via undo
Last modified: 2013-08-07 14:42:39 UTC
In CWS chart2mst3 if you insert a table and then insert a chart for that table a chart gets inserted and following that the new chart wizard dialog opens. If you press the 'Cancel' button the chart gets removed (by calling undo) but a redo action remains. Since the dialog was ended via 'Cancel' this should not happen. Thus it seems one of the following solutions are available. 1) remove the top redo action 2) may it is ok to remove all redo actions because when chart was inserted all prevous redo action got removed already 3) introduce some function like 'UndoWithoutRedo' The code line where the chart was removed with undo is in Writers chartins.cxx right after the line if( nDialogRet == ui::dialogs::ExecutableDialogResults::CANCEL ) TL->AMA: Please take over. Thanks!
.
Created attachment 38669 [details] sample document
If you use the attached document and remove all lines before the table and then insert a chart and cancelling exit the chart-wizard via cancel then now there won't be a redo on the stack! Maybe this is a problem that needs to be fixed as well. This seems to be different when you do the same with a new document though.
added keyword 'new_implementation' and string 'new chart:' to summary
Fixed in CWS chart2mst3 chartins.cxx 1.8.248.16 view.cxx 1.97.44.1 viewsh.hxx 1.50.72.1 viewsh.cxx 1.65.44.1 edtab.cxx 1.15.46.1
Ready for QA
changed target and type
Verified in CWS chart2mst3.
Checked in 680m214.